Making Bounds in VideoSourceConfiguration adaptable #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <para>Note for the VideoEncoderConfiguration: if necessary the device may adapt parameter values for Quality and RateControl elements without returning an error. A device shall adapt an out of range BitrateLimit instead of returning a fault.</para> | ||
| <para>Note for the AudioSourceConfiguration: If the new settings invalidate any parameters already negotiated using RTSP, for example by changing codec type, the device must not apply these settings to existing streams. Instead it must either continue to stream using the old settings or stop sending data on the affected streams.</para> | ||
| <para>Note for the VideoSourceConfiguration: If a Device supports Rotation and the new settings do not contain Rotate element, a device shall keep current rotation state.</para> | ||
| <para>Note for the VideoSourceConfiguration: If a Device supports Rotation and the new settings do not contain Rotate element, a device shall keep current rotation state. Moreover, if necessary the device may adapt parameter values for the Bounds element without returning an error. In case of adaptation of the parameter values, the device shall return the adapted values upon the client's request.</para> |
Contributor
There was a problem hiding this comment.
Suggest to include 'parameter values for e.g. X'? for better understanding
| <para>Note for the VideoEncoderConfiguration: if necessary the device may adapt parameter values for Quality and RateControl elements without returning an error. A device shall adapt an out of range BitrateLimit instead of returning a fault.</para> | ||
| <para>Note for the AudioSourceConfiguration: If the new settings invalidate any parameters already negotiated using RTSP, for example by changing codec type, the device must not apply these settings to existing streams. Instead it must either continue to stream using the old settings or stop sending data on the affected streams.</para> | ||
| <para>Note for the VideoSourceConfiguration: If a Device supports Rotation and the new settings do not contain Rotate element, a device shall keep current rotation state.</para> | ||
| <para>Note for the VideoSourceConfiguration: If a Device supports Rotation and the new settings do not contain Rotate element, a device shall keep current rotation state. Moreover, if necessary the device may adapt parameter values for the Bounds element without returning an error. In case of adaptation of the parameter values, the device shall return the adapted values upon the client's request.</para> |
Contributor
There was a problem hiding this comment.
Suggested change
| <para>Note for the VideoSourceConfiguration: If a Device supports Rotation and the new settings do not contain Rotate element, a device shall keep current rotation state. Moreover, if necessary the device may adapt parameter values for the Bounds element without returning an error. In case of adaptation of the parameter values, the device shall return the adapted values upon the client's request.</para> | |
| <para>Note for the VideoSourceConfiguration: If a Device supports Rotation and the new settings do not contain Rotate element, a device shall keep current rotation state. Moreover, if necessary the device may adapt parameter values for the Bounds element without returning an error. If certain parameters adapt, the device shall return the adapted values upon the client's request.</para> |
Collaborator
Author
There was a problem hiding this comment.
@bsriramprasad I think that the original wording is better, because it is the camera that changes the parameters and not the parameters changing on their own. @kieran242, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request related to the presentation given during the F2F meeting in Kaula Lumpur to make bounds range adaptable